wireguard-openbsd/sys/dev/midi.c, branch jd/queueboosts

Abstract the head of knote lists. This allows extending the lists,

2020-04-07T13:27:50Z

for example, with locking assertions. OK mpi@, anton@

Replace field f_isfd with field f_flags in struct filterops to allow

2020-02-20T16:56:51Z

adding more filter properties without cluttering the struct. OK mpi@, anton@

Use C99 designated initializers with struct filterops. In addition,

2019-12-31T13:48:31Z

make the structs const so that the data are put in .rodata. OK mpi@, deraadt@, anton@, bluhm@

midi(4): sleep(9) -> sleep_nsec(9)

2019-12-22T19:11:45Z

These are straightforward except for the tsleep(9) conversion. ratchov@ had a bit to say about that code: https://marc.info/?l=openbsd-tech&m=157665936017373&w=2 > The problem is that close(2) may reset the transmitter before the few > bytes of its internal buffer is sent on the wire; there's no "wait for > completion" feature in such simple hardware, so we just wait few > milliseconds. > > The transmitter buffer size is around 16 bytes, the byte rate is 3125 > bytes/second. So if we wait at least 16B / 3125B/s = 5.12ms, we're > safe. Waiting 10ms-20ms is enough and is unnoticeable. Hence, in this diff we wait a flat 20ms in that situation. ok ratchov@

Remove SIGIO support. The audio(4) driver doesn't implement it either and

2017-07-19T22:23:54Z

the preferred method to access MIDI hardware is through sndiod(8) which doesn't use it. Fixes a potential issue with a stale struct proc pointer found by Ilja van Sprundel. ok deraadt@, ratchov@

No need to include sys/malloc.h. From Michael W. Bombardieri. Thanks.

2017-01-03T06:39:44Z

In midiread() and midiwrite(), add a second goto label to

2016-12-20T16:03:39Z

factor calls to mtx_leave() before returning. From Michael W. Bombardieri . Thanks!

Don't use an uninitialised softc pointer in midiread/midiwrite.

2015-05-22T12:52:00Z

ok ratchov@

Use device_lookup() instead of digging into midi_cd.cd_devs[] and

2015-05-16T09:56:10Z

maintaining a "dying" flag which is already present in the device structure. As a side-effect, this adds the missing refcounting that mididetach() was missing. With from mpi@ and dlg@ ok mpi

remove the sc->isopen flag, as sc->flags already hold the

2015-05-12T18:39:30Z

same information.