wireguard-openbsd/sys/scsi, branch master

spelling

2021-03-12T10:22:46Z

TL;DR -- don't configure devices that return insufficient INQUIRY data.

2020-11-19T13:45:15Z

Treat INQUIRY data with fewer than SID_SCSI2_HDRLEN bytes as invalid. Use only INQUIRY data returned by the device. Get all available INQUIRY data (up to sizeof(struct scsi_inquiry_data)) even when SCSIDEBUG is not set. Tweak returned INQUIRY data so additional_length field does not point past end of returned data when available data is greater than sizeof(struct scsi_inquiry_data). Missing dmafree() spotted by gnezdo@. ok jmatthew@.

Introduce scsi_copy_internal_data() to copy 'faked' data from a driver to a

2020-10-14T23:40:33Z

scsi_xfer. Will replace various equivalent functions/hand-rolled chunks, none of which were setting xs->resid.

Remove 'void *sc_sdhook' member of sd_softc.

2020-09-23T15:24:16Z

Unused since mpi@ removed sd_shutdown() in 2014.

Since dlg@'s 2009 scsi midlayer refactoring the 'struct scsi_generic *cmd'

2020-09-22T19:32:51Z

member of 'struct scsi_xfer' has always been pointed at the 'struct scsi_generic cmdstore' member of the same instance. So nuke 'cmdstore' and remove the '*' from cmd. Take the address of cmd as required by the various casts. No intentional functional change. luna88k test by aoyama@, sparc64 test by jmatthew@ Identification of 2009's last *cmd use and ok jmatthew@

No need to check for SDEV_DYING as the first thing in both branches of an

2020-09-14T18:44:54Z

if/else. Just do it once before the if. Move the SC_DEBUG() documenting entry into sdopen() to before the various error bailouts.

Always use READ(16)/WRITE(16) commands for disks large enough to require

2020-09-13T14:26:56Z

READ(16)/WRITE(16) to access the last sectors Fixes (at least) large 512E (a.k.a. emulated 512-byte sector) devices plugged into overly helpful USB <-> ATA/ATAPI bridges. Which can tell you they are using 512-byte sector addresses but spontaneously/silently interpret READ(10)/WRITE(10) commands as using 4K sector addresses/sizes. Diagnosed and fix tested with James Cook. Thanks!

Use SID_SCSI2_RESPONSE instead of '2' when checking INQUIRY data format.

2020-09-12T17:03:51Z

No need to check inq for NULL when it always points at the inqdata inside a

2020-09-12T16:51:04Z

scsi_link.

No need to ask for extra INQUIRY data, all available data is already cached in

2020-09-12T15:54:51Z

scsi_link's inqdata.