summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorclaudio <claudio@openbsd.org>2014-11-23 13:10:30 +0000
committerclaudio <claudio@openbsd.org>2014-11-23 13:10:30 +0000
commitefb506e89bb472d46424b4c610e654fc4cdddb19 (patch)
tree9105d059e87ff3d5da8e50423e7827bf9de27e91
parentChange the error handling a bit to ensure we do not double free the task (diff)
downloadwireguard-openbsd-efb506e89bb472d46424b4c610e654fc4cdddb19.tar.xz
wireguard-openbsd-efb506e89bb472d46424b4c610e654fc4cdddb19.zip
TargetPortalGroupTag is a binary 16-bit value so 0 is allowed.
Still not perfect since binary values can also be base64 encoded but one step closer.
-rw-r--r--usr.sbin/iscsid/connection.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/usr.sbin/iscsid/connection.c b/usr.sbin/iscsid/connection.c
index 044abbad149..3f7c3279f5d 100644
--- a/usr.sbin/iscsid/connection.c
+++ b/usr.sbin/iscsid/connection.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: connection.c,v 1.19 2014/05/10 11:30:47 claudio Exp $ */
+/* $OpenBSD: connection.c,v 1.20 2014/11/23 13:10:30 claudio Exp $ */
/*
* Copyright (c) 2009 Claudio Jeker <claudio@openbsd.org>
@@ -289,13 +289,14 @@ conn_parse_kvp(struct connection *c, struct kvp *kvp)
for (k = kvp; k->key; k++) {
+log_debug("conn_parse_kvp: %s = %s", k->key, k->value);
/* XXX handle NotUnderstood|Irrelevant|Reject */
SET_NUM(k, s, MaxBurstLength, 512, 16777215);
SET_NUM(k, s, FirstBurstLength, 512, 16777215);
SET_NUM(k, s, DefaultTime2Wait, 0, 3600);
SET_NUM(k, s, DefaultTime2Retain, 0, 3600);
SET_NUM(k, s, MaxOutstandingR2T, 1, 65535);
- SET_NUM(k, s, TargetPortalGroupTag, 1, 65535);
+ SET_NUM(k, s, TargetPortalGroupTag, 0, 65535);
SET_NUM(k, s, MaxConnections, 1, 65535);
SET_BOOL(k, s, InitialR2T);
SET_BOOL(k, s, ImmediateData);