diff options
| author | 2015-01-27 03:17:35 +0000 | |
|---|---|---|
| committer | 2015-01-27 03:17:35 +0000 | |
| commit | e419548092f59c20a140404818050eb2ab331a19 (patch) | |
| tree | ff250435e8b28c07c967073741c21d374241b774 /sys/dev/pci/mpii.c | |
| parent | Remove an unused and confusing assignment that had been commented out for (diff) | |
| download | wireguard-openbsd-e419548092f59c20a140404818050eb2ab331a19.tar.xz wireguard-openbsd-e419548092f59c20a140404818050eb2ab331a19.zip | |
remove the second void * argument on tasks.
when workqs were introduced, we provided a second argument so you
could pass a thing and some context to work on it in. there were
very few things that took advantage of the second argument, so when
i introduced pools i suggested removing it. since tasks were meant
to replace workqs, it was requested that we keep the second argument
to make porting from workqs to tasks easier.
now that workqs are gone, i had a look at the use of the second
argument again and found only one good use of it (vdsp(4) on sparc64
if you're interested) and a tiny handful of questionable uses. the
vast majority of tasks only used a single argument. i have since
modified all tasks that used two args to only use one, so now we
can remove the second argument.
so this is a mechanical change. all tasks only passed NULL as their
second argument, so we can just remove it.
ok krw@
Diffstat (limited to 'sys/dev/pci/mpii.c')
| -rw-r--r-- | sys/dev/pci/mpii.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/dev/pci/mpii.c b/sys/dev/pci/mpii.c index 6ce2d4ddca9..4d68b172dd1 100644 --- a/sys/dev/pci/mpii.c +++ b/sys/dev/pci/mpii.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mpii.c,v 1.97 2014/09/16 05:12:04 dlg Exp $ */ +/* $OpenBSD: mpii.c,v 1.98 2015/01/27 03:17:36 dlg Exp $ */ /* * Copyright (c) 2010, 2012 Mike Belopuhov * Copyright (c) 2009 James Giannoules @@ -340,7 +340,7 @@ void mpii_eventack(void *, void *); void mpii_eventack_done(struct mpii_ccb *); void mpii_event_process(struct mpii_softc *, struct mpii_rcb *); void mpii_event_done(struct mpii_softc *, struct mpii_rcb *); -void mpii_event_sas(void *, void *); +void mpii_event_sas(void *); void mpii_event_raid(struct mpii_softc *, struct mpii_msg_event_reply *); @@ -1550,7 +1550,7 @@ mpii_eventnotify(struct mpii_softc *sc) SIMPLEQ_INIT(&sc->sc_evt_sas_queue); mtx_init(&sc->sc_evt_sas_mtx, IPL_BIO); - task_set(&sc->sc_evt_sas_task, mpii_event_sas, sc, NULL); + task_set(&sc->sc_evt_sas_task, mpii_event_sas, sc); SIMPLEQ_INIT(&sc->sc_evt_ack_queue); mtx_init(&sc->sc_evt_ack_mtx, IPL_BIO); @@ -1695,7 +1695,7 @@ mpii_event_raid(struct mpii_softc *sc, struct mpii_msg_event_reply *enp) } void -mpii_event_sas(void *xsc, void *x) +mpii_event_sas(void *xsc) { struct mpii_softc *sc = xsc; struct mpii_rcb *rcb, *next; |
