summaryrefslogtreecommitdiffstats
path: root/sys/dev/usb/if_upl.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Do not call encap routines with the IFQ mutex held, as they mightgerhard2020-06-091-5/+4
| | | | | | sleep in the stop routine in case of errors. Fix proposed by mpi@, ok patrick@
* Make some USB ioctls return ENXIO, instead of EIO, if usbd_is_dying().stsp2018-10-021-2/+2
| | | | | | | Brings us one step closer towards making this condition's error code consistent across all USB drivers. Patch by Moritz Buhl ok mpi@ bluhm@
* IFF_NOARP has no effect if the interface don't use ether_input() normpi2017-10-291-2/+2
| | | | ether_output().
* move counting if_opackets next to counting if_obytes in if_enqueue.dlg2017-01-221-3/+1
| | | | | | | this means packets are consistently counted in one place, unlike the many and various ways that drivers thought they should do it. ok mpi@ deraadt@
* Avoid calling usbd_set_config_no() in *_attach() and let the stack dompi2016-11-061-9/+2
| | | | | | | | | it instead. If anything bad happen due to a malformed descriptor it makes no sense to try to attach a driver, and bail before probing. This is similar to the change to avoid calling usbd_set_config_index().
* G/C IFQ_SET_READY().mpi2016-04-131-2/+1
|
* Network drivers should not include <net/route.h> or <net/netisr.h>mpi2015-11-251-2/+1
|
* replace IFF_OACTIVE manipulation with mpsafe operations.dlg2015-11-251-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | there are two things shared between the network stack and drivers in the send path: the send queue and the IFF_OACTIVE flag. the send queue is now protected by a mutex. this diff makes the oactive functionality mpsafe too. IFF_OACTIVE is part of if_flags. there are two problems with that. firstly, if_flags is a short and we dont have any MI atomic operations to manipulate a short. secondly, while we could make the IFF_OACTIVE operates mpsafe, all changes to other flags would have to be made safe at the same time, otherwise a read-modify-write cycle on their updates could clobber the oactive change. instead, this moves the oactive mark into struct ifqueue and provides an API for changing it. there's ifq_set_oactive, ifq_clr_oactive, and ifq_is_oactive. these are modelled on ifsq_set_oactive, ifsq_clr_oactive, and ifsq_is_oactive in dragonflybsd. this diff includes changes to all the drivers manipulating IFF_OACTIVE to now use the ifsq_{set,clr_is}_oactive API too. ok kettenis@ mpi@ jmatthew@ deraadt@
* shuffle struct ifqueue so in flight mbufs are protected by a mutex.dlg2015-11-201-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the code is refactored so the IFQ macros call newly implemented ifq functions. the ifq code is split so each discipline (priq and hfsc in our case) is an opaque set of operations that the common ifq code can call. the common code does the locking, accounting (ifq_len manipulation), and freeing of the mbuf if the disciplines enqueue function rejects it. theyre kind of like bufqs in the block layer with their fifo and nscan disciplines. the new api also supports atomic switching of disciplines at runtime. the hfsc setup in pf_ioctl.c has been tweaked to build a complete hfsc_if structure which it attaches to the send queue in a single operation, rather than attaching to the interface up front and building up a list of queues. the send queue is now mutexed, which raises the expectation that packets can be enqueued or purged on one cpu while another cpu is dequeueing them in a driver for transmission. a lot of drivers use IFQ_POLL to peek at an mbuf and attempt to fit it on the ring before committing to it with a later IFQ_DEQUEUE operation. if the mbuf gets freed in between the POLL and DEQUEUE operations, fireworks will ensue. to avoid this, the ifq api introduces ifq_deq_begin, ifq_deq_rollback, and ifq_deq_commit. ifq_deq_begin allows a driver to take the ifq mutex and get a reference to the mbuf they wish to try and tx. if there's space, they can ifq_deq_commit it to remove the mbuf and release the mutex. if there's no space, ifq_deq_rollback simply releases the mutex. this api was developed to make updating the drivers using IFQ_POLL easy, instead of having to do significant semantic changes to avoid POLL that we cannot test on all the hardware. the common code has been tested pretty hard, and all the driver modifications are straightforward except for de(4). if that breaks it can be dealt with later. ok mpi@ jmatthew@
* Rename if_output() into if_enqueue() to avoid confusion with commentsmpi2015-06-301-2/+2
| | | | | | talking about (*ifp->if_output)(). ok claudio@, dlg@
* Increment if_ipackets in if_input().mpi2015-06-241-2/+1
| | | | | | | Note that pseudo-drivers not using if_input() are not affected by this conversion. ok mikeb@, kettenis@, claudio@, dlg@
* Convert to if_output().mpi2015-05-211-25/+2
|
* Convert remaining USB Ethernet adapter to if_input().mpi2015-04-101-20/+6
| | | | ok dlg@
* Remove some includes include-what-you-use claims don'tjsg2015-03-141-2/+1
| | | | | | | have any direct symbols used. Tested for indirect use by compiling amd64/i386/sparc64 kernels. ok tedu@ deraadt@
* Kill annoying comments about ether_input()mpi2015-02-041-7/+1
|
* Some missing break's.brad2014-12-291-2/+3
|
* Some cleaning up of the ioctl handling bits to bring things in linebrad2014-12-291-21/+17
| | | | with the other drivers.
* unifdef INETtedu2014-12-221-3/+1
|
* No need for <netinet/in_systm.h> here.mpi2014-07-131-7/+1
|
* Kill a bunch of DVACT_DEACTIVATE handlers whose only purpose were tompi2014-07-121-31/+11
| | | | | | | | | | | | | | set the 'dying' flag of a device. Such handlers are useless now that usbd_detach() already set this flag. Even if the purpose of this flag is questionnable on OpenBSD because DVACT_DEACTIVATE acts as a pre-detach event, this is just a first small step towards the simplification of the autoconf(9) device states. This cleaning is now possible thanks to the work of pirofti@ to convert all the USB drivers to properly use usbd_is_dying(). Discussed many times with deraadt@
* Remove unused fields.mpi2014-01-071-5/+1
| | | | ok sasano@
* Clean-up usbd_abort_pipe() usage.pirofti2013-11-151-16/+4
| | | | | | | This function never fails. So change it's return type to void and adjust the copy-pasted callers that were checking the return. "If it compiles, ok" mpi@
* Replace sc_dying in favour of usbd_is_dying() and usbd_deactivate().pirofti2013-11-061-10/+9
| | | | Okay mpi@
* Kill sc_attached, attach and detach events for USB devices are triggeredmpi2013-10-291-8/+1
| | | | by the same explore task and cannot happen in parallel.
* Most network drivers include netinet/in_var.h, but apparently theybluhm2013-08-071-2/+1
| | | | | don't have to. Just remove these include lines. Compiled on amd64 i386 sparc64; OK henning@ mikeb@
* Get rid of various 'typedef struct' definitions and use plain structuremglocker2013-04-151-13/+13
| | | | | | | | | definitions instead. We don't change usb.h for now to stay compatible with userland. Tested by mpi@ on macppc and myself on i386. ok mpi@
* Remove dead code.mpi2013-02-071-30/+1
| | | | ok mikeb@
* - Use IF_Gbps(1) instead of IF_Mbps(1000)brad2012-11-281-2/+2
| | | | | | | | | - Use IF_Mbps() instead of multiplying the link speed by a bare value - Remove a useless comment as baudrate is already handled properly - Remove some commented out bits of code - Use IF_Mbps() instead of the bare value ok sthen@
* Remove config_activate() and DVACT_ACTIVATE. PCMCIA's the only thingmatthew2011-07-031-4/+1
| | | | | | | | that's ever used it, and it's long since been changed to use DVACT_{QUIESCE,SUSPEND,RESUME} instead. ok deraadt@, dlg@; miod@ also agreed with this idea when I brought it up a few weeks ago
* garbage collect "usb events". without /dev/usb there is no way to accessjakemsr2011-01-251-7/+1
| | | | | | them from userland, and nothing in the kernel uses them. ok krw@, miod@
* - use usb_lookup() instead of handrolled macro.jasper2010-12-171-15/+5
| | | | ok jakemsr@
* a couple unchecked if_detach() in detach routines that were missedjakemsr2010-12-061-2/+3
| | | | in previous sweep (avoid NULL deref if the device didn't fully attach)
* remove dying flag in detach() function.yuo2010-09-241-7/+5
| | | | | | The dying flag will be set in activate()/DEACTIVATE. ok deraadt@
* Get rid of devact enum, substitute it with an int and coresponding defines.pirofti2009-10-131-3/+3
| | | | | | This is needed for the addition of further suspend/resume actions. Okay deraadt@, marco@.
* Return ENOTTY for unknown ioctl's.brad2008-10-031-3/+2
|
* First pass at removing clauses 3 and 4 from NetBSD licenses.ray2008-06-261-8/+1
| | | | | | | | | Not sure what's more surprising: how long it took for NetBSD to catch up to the rest of the BSDs (including UCB), or the amount of code that NetBSD has claimed for itself without attributing to the actual authors. OK deraadt@
* treat usb vendor/product names as a locator, and have usbd_print handle it,deraadt2007-10-111-6/+1
| | | | | | so that it shows up before the :. as a result, all the usb devices do not need to have name printing code anymore. all this now works and prints nicely because usbd_probe_and_attach() is serialized. ok kettenis
* remove unneeded malloc.h include.fgsch2007-09-171-2/+1
|
* Remove the definition and usage of the USB_DECLARE_DRIVER_CLASS andmbalmer2007-06-141-2/+17
| | | | | | | | USB_DECLARE_DRIVER macros. No binary change. ok dlg.
* Remove the definition and usage of the IF_INPUT macro which was definedmbalmer2007-06-131-2/+2
| | | | | | | | as ether_input_mbuf which is itself a macro for ether_input. No binary change. ok dlg.
* Remove the definition and use of the device_ptr_t which was a struct device *.mbalmer2007-06-121-2/+2
| | | | | | No binary change. ok mk.
* Remove the definition and use of the USBDEVNAME macro.mbalmer2007-06-101-44/+44
| | | | | | | (This might look easy, but it was a big diff. Thanks to dlg and especially jsg for looking over it; we found at least four mistakes in the initial diff.) ok jsg.
* Remove the definition and use of the USBDEV macro. It only created confusionmbalmer2007-06-101-3/+3
| | | | | | | | and the address of it's argument: USBDEV(sc->sc_dev) yields &sc->sc_dev. No binary changes. ok jsg.
* Remove definitions and usage of usb_callout and related macros. These macrosmbalmer2007-06-101-2/+2
| | | | | | | | were used as a layer of confusion^Wabstraction around the timeout(9) API. No binary change. ok jsg.
* Remove the definition and use of if_deactivate(). It was defined empty andmbalmer2007-06-091-3/+1
| | | | | | | | thus produced no code at all. No binary change. ok jsg.
* Mechanical removal of USBBASEDEVICE. No binary change.mk2007-06-061-2/+2
| | | | | | Tested by thib and myself. ok mbalmer jsg
* Remove the "Static" declaration of many functions. It was defined to be emptymbalmer2007-06-051-33/+33
| | | | | | | and it was not consistently used. It was confusing as it suggested these functions were static, which they were not. discussed with dlg and jsg, ok jsg.
* Remove more Free(?)BSD and NetBSD #ifdef/#endifs. No functional normbalmer2007-06-011-20/+1
| | | | | | binary change. ok jsg
* Farewell USB_{ATTACH,MATCH,DETACH}* you will not be missed.jsg2007-05-271-15/+16
| | | | ok deraadt@ krw@ mbalmer@
* Remove logprintf macrojsg2007-05-211-3/+3
|
Copyright © 1996 – 2023 Jason A. Donenfeld. All Rights Reverse Engineered.