From f89006065eca017d53982d8889121e043d650370 Mon Sep 17 00:00:00 2001 From: angelos Date: Mon, 15 May 2000 03:38:40 +0000 Subject: Add comment on input MSS calculation based on previous PMTUD results, as per TCP-imply IETF WG draft(s). The correct approach is to just use the relevant interface's MTU. --- sys/netinet/tcp_input.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 1ed40938e1b..ee7650e0487 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -1,4 +1,4 @@ -/* $OpenBSD: tcp_input.c,v 1.60 2000/04/28 00:31:48 itojun Exp $ */ +/* $OpenBSD: tcp_input.c,v 1.61 2000/05/15 03:38:40 angelos Exp $ */ /* $NetBSD: tcp_input.c,v 1.23 1996/02/13 23:43:44 christos Exp $ */ /* @@ -2790,6 +2790,13 @@ tcp_mss(tp, offer) * if there's an mtu associated with the route and we support * path MTU discovery for the underlying protocol family, use it. */ + /* + * XXX It's wrong to use PMTU values to determine the MSS we + * are going to advertise; we should only use the input interface's + * MTU instead (see draft-ietf-tcpimpl-pmtud-03.txt). tcp_mss() + * should be changed to be aware whether it's called for input or + * output MSS calculation, and act accordingly. + */ if (rt->rt_rmx.rmx_mtu) { /* * One may wish to lower MSS to take into account options, -- cgit v1.2.3-59-g8ed1b