From df69c215c7c66baf660f3f65414fd34796c96152 Mon Sep 17 00:00:00 2001 From: deraadt Date: Fri, 28 Jun 2019 13:32:41 +0000 Subject: When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future. --- lib/libkvm/kvm_proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/libkvm/kvm_proc.c') diff --git a/lib/libkvm/kvm_proc.c b/lib/libkvm/kvm_proc.c index a18e9983ae0..f2733ccfc26 100644 --- a/lib/libkvm/kvm_proc.c +++ b/lib/libkvm/kvm_proc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: kvm_proc.c,v 1.59 2018/05/03 15:47:41 zhuk Exp $ */ +/* $OpenBSD: kvm_proc.c,v 1.60 2019/06/28 13:32:42 deraadt Exp $ */ /* $NetBSD: kvm_proc.c,v 1.30 1999/03/24 05:50:50 mrg Exp $ */ /*- * Copyright (c) 1998 The NetBSD Foundation, Inc. @@ -491,7 +491,7 @@ again: mib[3] = isenv ? KERN_PROC_ENV : KERN_PROC_ARGV; len = orglen; - ret = (sysctl(mib, 4, *pargbuf, &len, NULL, 0) < 0); + ret = (sysctl(mib, 4, *pargbuf, &len, NULL, 0) == -1); if (ret && errno == ENOMEM) { buf = _kvm_reallocarray(kd, *pargbuf, orglen, 2); if (buf == NULL) -- cgit v1.2.3-59-g8ed1b