From 06b8b6ab5c855a9f81e90ed1bf3033902fa7a22d Mon Sep 17 00:00:00 2001
From: Alexander Neumann <alexander.neumann@picos-software.com>
Date: Wed, 23 Oct 2019 18:03:48 +0200
Subject: TreeView: Enable performance improvements by not counting all
 children

---
 models.go   |  6 ++++++
 treeview.go | 13 ++++++++++---
 2 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/models.go b/models.go
index 17049b31..c56510d9 100644
--- a/models.go
+++ b/models.go
@@ -597,6 +597,12 @@ type TreeItem interface {
 	ChildAt(index int) TreeItem
 }
 
+// HasChilder enables widgets like TreeView to determine if an item has any
+// child, without enforcing to fully count all children.
+type HasChilder interface {
+	HasChild() bool
+}
+
 // TreeModel provides widgets like TreeView with item data.
 type TreeModel interface {
 	// LazyPopulation returns if the model prefers on-demand population.
diff --git a/treeview.go b/treeview.go
index 6e8b7ea1..7458e647 100644
--- a/treeview.go
+++ b/treeview.go
@@ -171,6 +171,7 @@ func (tv *TreeView) SetModel(model TreeModel) error {
 
 		tv.itemInsertedEventHandlerHandle = model.ItemInserted().Attach(func(item TreeItem) {
 			tv.SetSuspended(true)
+			defer tv.SetSuspended(false)
 
 			var hInsertAfter win.HTREEITEM
 			parent := item.Parent()
@@ -187,8 +188,6 @@ func (tv *TreeView) SetModel(model TreeModel) error {
 			if _, err := tv.insertItemAfter(item, hInsertAfter); err != nil {
 				return
 			}
-
-			tv.SetSuspended(false)
 		})
 
 		tv.itemRemovedEventHandlerHandle = model.ItemRemoved().Attach(func(item TreeItem) {
@@ -587,7 +586,15 @@ func (tv *TreeView) WndProc(hwnd win.HWND, msg uint32, wParam, lParam uintptr) u
 				(*buf)[max-1] = 0
 			}
 			if nmtvdi.Item.Mask&win.TVIF_CHILDREN != 0 {
-				nmtvdi.Item.CChildren = int32(item.ChildCount())
+				if hc, ok := item.(HasChilder); ok {
+					if hc.HasChild() {
+						nmtvdi.Item.CChildren = 1
+					} else {
+						nmtvdi.Item.CChildren = 0
+					}
+				} else {
+					nmtvdi.Item.CChildren = int32(item.ChildCount())
+				}
 			}
 
 		case win.TVN_ITEMEXPANDING:
-- 
cgit v1.2.3-59-g8ed1b