From d47c99646b832b30bdba7fb3fe22a883454544ab Mon Sep 17 00:00:00 2001 From: "Jason A. Donenfeld" Date: Wed, 20 Mar 2019 23:36:34 -0600 Subject: errors: don't put periods at end of errors --- service/errors.go | 34 +++++++++++++++++----------------- ui/ui.go | 6 +++++- 2 files changed, 22 insertions(+), 18 deletions(-) diff --git a/service/errors.go b/service/errors.go index 02ca33dc..a2050460 100644 --- a/service/errors.go +++ b/service/errors.go @@ -35,39 +35,39 @@ const ( func (e Error) Error() string { switch e { case ErrorSuccess: - return "No error." + return "No error" case ErrorRingloggerOpen: - return "Unable to open log file." + return "Unable to open log file" case ErrorDetermineExecutablePath: - return "Unable to determine path of running executable." + return "Unable to determine path of running executable" case ErrorLoadConfiguration: - return "Unable to load configuration from path." + return "Unable to load configuration from path" case ErrorCreateWintun: - return "Unable to create Wintun device." + return "Unable to create Wintun device" case ErrorDetermineWintunName: - return "Unable to determine Wintun name." + return "Unable to determine Wintun name" case ErrorUAPIListen: - return "Unable to listen on named pipe." + return "Unable to listen on named pipe" case ErrorUAPISerialization: - return "Unable to serialize configuration into uapi form." + return "Unable to serialize configuration into uapi form" case ErrorDeviceSetConfig: - return "Unable to set device configuration." + return "Unable to set device configuration" case ErrorBindSocketsToDefaultRoutes: - return "Unable to bind sockets to default route." + return "Unable to bind sockets to default route" case ErrorSetNetConfig: - return "Unable to set interface addresses, routes, dns, and/or adapter settings." + return "Unable to set interface addresses, routes, dns, and/or adapter settings" case ErrorFindAdministratorsSID: - return "Unable to find Administrators SID." + return "Unable to find Administrators SID" case ErrorOpenNULFile: - return "Unable to open NUL file." + return "Unable to open NUL file" case ErrorTrackTunnels: - return "Unable to track existing tunnels." + return "Unable to track existing tunnels" case ErrorEnumerateSessions: - return "Unable to enumerate current sessions." + return "Unable to enumerate current sessions" case ErrorWin32: - return "An internal Windows error has occurred." + return "An internal Windows error has occurred" default: - return "An unknown error has occurred." + return "An unknown error has occurred" } } diff --git a/ui/ui.go b/ui/ui.go index bbae9980..3f8f53a1 100644 --- a/ui/ui.go +++ b/ui/ui.go @@ -261,7 +261,11 @@ func RunUI() { setServiceState(tunnel, state, err == nil) if err != nil { if mw.Visible() { - walk.MsgBox(mw, "Tunnel Error", err.Error()+"\n\nPlease consult the log for more information.", walk.MsgBoxIconWarning) + errMsg := err.Error() + if len(errMsg) > 0 && errMsg[len(errMsg)-1] != '.' { + errMsg += "." + } + walk.MsgBox(mw, "Tunnel Error", errMsg+"\n\nPlease consult the log for more information.", walk.MsgBoxIconWarning) } else { tray.ShowError("WireGuard Tunnel Error", err.Error()) } -- cgit v1.2.3-59-g8ed1b