aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Helmert III <ajak@gentoo.org>2022-06-15 17:11:17 -0500
committerMike Gilbert <floppym@gentoo.org>2022-06-17 13:01:49 -0400
commit9ab9368c3324d615f1234d1ccb03eae939c393cf (patch)
tree9061bd59de679d44a85569d0c60ccdecc6469c4d
parentFix variable typo (diff)
downloadgentoo-portage-9ab9368c3324d615f1234d1ccb03eae939c393cf.tar.xz
gentoo-portage-9ab9368c3324d615f1234d1ccb03eae939c393cf.zip
depclean: return failure when requested packages aren't depcleaned
Closes: https://bugs.gentoo.org/851750 Closes: https://github.com/gentoo/portage/pull/840 Signed-off-by: John Helmert III <ajak@gentoo.org> Signed-off-by: Mike Gilbert <floppym@gentoo.org>
-rw-r--r--lib/_emerge/actions.py5
1 files changed, 5 insertions, 0 deletions
diff --git a/lib/_emerge/actions.py b/lib/_emerge/actions.py
index 0bf2d88b1..e2f3f2ccf 100644
--- a/lib/_emerge/actions.py
+++ b/lib/_emerge/actions.py
@@ -1697,6 +1697,11 @@ def _calc_depclean(settings, trees, ldpath_mtimes, myopts, action, args_set, spi
cleanlist.append(node.cpv)
return _depclean_result(0, cleanlist, ordered, required_pkgs_total, resolver)
+ if args_set and "--pretend" not in myopts:
+ # If the cleanlist is empty but we were given packages to clean,
+ # we aren't successfully depcleaning. Return failure unless
+ # we're pretending.
+ return _depclean_result(1, [], False, required_pkgs_total, resolver)
return _depclean_result(0, [], False, required_pkgs_total, resolver)