diff options
| author |   Abhishek Ojha <abhishek.ojha@savoirfairelinux.com> | 2026-09-16 19:19:28 -0400 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2026-09-18 17:07:41 -0700 |
| commit | 95c4d54ed02283e9a09e8cd7360e384daa67a741 (patch) | |
| tree | e9a0c9ca479020476b1089d69c45d3b6d66f7307 | |
| parent | ip6_gre: Call ip6erspan_tunnel_unlink_md() in ip6erspan_changelink(). (diff) | |
net: phy: micrel: Advance register data pointer in write loop
lanphy_write_reg_data() does not advance the data pointer while iterating
over the register table. As a result, it writes the first entry num times
and leaves the remaining errata registers unconfigured.
Single-entry tables are unaffected, but tables with multiple entries
leave every entry after the first unapplied.
Advance the data pointer after each successful write so every table entry
is applied in order.
Fixes: c8732e933925 ("net: phy: micrel: lan8842 errata")
Cc: stable@vger.kernel.org
Signed-off-by: Abhishek Ojha <abhishek.ojha@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260916231928.1336305-1-abhishek.ojha@savoirfairelinux.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/phy/micrel.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index ae830781824b..5c8461db7b4b 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -6344,6 +6344,7 @@ static int lanphy_write_reg_data(struct phy_device *phydev, data->val); if (ret) break; + data++; } return ret; |