aboutsummaryrefslogtreecommitdiffstats
path: root/include/net/ssh:/git@git.zx2c4.com
diff options
context:
space:
mode:
authorDaeMyung Kang <charsyam@gmail.com>2026-04-17 06:17:35 +0900
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2026-04-27 07:30:18 -0600
commit002a3de980a9b7f36a487c91d769ce1ab9c07a11 (patch)
treef2afe13caf412a418955421de71b28c660663f32 /include/net/ssh:/git@git.zx2c4.com
parentsmb: client: fix dir separator in SMB1 UNIX mounts (diff)
smb: server: fix max_connections off-by-one in tcp accept path
commit ce23158bfe584bd90d1918f279fdf9de57802012 upstream. The global max_connections check in ksmbd's TCP accept path counts the newly accepted connection with atomic_inc_return(), but then rejects the connection when the result is greater than or equal to server_conf.max_connections. That makes the effective limit one smaller than configured. For example: - max_connections=1 rejects the first connection - max_connections=2 allows only one connection The per-IP limit in the same function uses <= correctly because it counts only pre-existing connections. The global limit instead checks the post-increment total, so it should reject only when that total exceeds the configured maximum. Fix this by changing the comparison from >= to >, so exactly max_connections simultaneous connections are allowed and the next one is rejected. This matches the documented meaning of max_connections in fs/smb/server/ksmbd_netlink.h as the "Number of maximum simultaneous connections". Fixes: 0d0d4680db22 ("ksmbd: add max connections parameter") Cc: stable@vger.kernel.org Signed-off-by: DaeMyung Kang <charsyam@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/net/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions