aboutsummaryrefslogtreecommitdiffstats
path: root/tools/debugging/git:/ssh:/git@git.zx2c4.com
diff options
context:
space:
mode:
authorDevarsh Thakkar <devarsht@ti.com>2025-10-20 08:58:35 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-23 16:24:39 +0200
commitde1a3f537aed174ba562baf0d125392d47831fd8 (patch)
treee511de76791715e0d48223a3d74d67d673d37c14 /tools/debugging/git:/ssh:/git@git.zx2c4.com
parentphy: cdns-dphy: Store hs_clk_rate and return it (diff)
downloadlaptop-kernel-de1a3f537aed174ba562baf0d125392d47831fd8.tar.xz
laptop-kernel-de1a3f537aed174ba562baf0d125392d47831fd8.zip
phy: cadence: cdns-dphy: Fix PLL lock and O_CMN_READY polling
[ Upstream commit 284fb19a3ffb1083c3ad9c00d29749d09dddb99c ] PLL lockup and O_CMN_READY assertion can only happen after common state machine gets enabled by programming DPHY_CMN_SSM register, but driver was polling them before the common state machine was enabled which is incorrect. This is as per the DPHY initialization sequence as mentioned in J721E TRM [1] at section "12.7.2.4.1.2.1 Start-up Sequence Timing Diagram". It shows O_CMN_READY polling at the end after common configuration pin setup where the common configuration pin setup step enables state machine as referenced in "Table 12-1533. Common Configuration-Related Setup mentions state machine" To fix this : - Add new function callbacks for polling on PLL lock and O_CMN_READY assertion. - As state machine and clocks get enabled in power_on callback only, move the clock related programming part from configure callback to power_on callback and poll for the PLL lockup and O_CMN_READY assertion after state machine gets enabled. - The configure callback only saves the PLL configuration received from the client driver which will be applied later on in power_on callback. - Add checks to ensure configure is called before power_on and state machine is in disabled state before power_on callback is called. - Disable state machine in power_off so that client driver can re-configure the PLL by following up a power_off, configure, power_on sequence. [1]: https://www.ti.com/lit/zip/spruil1 Cc: stable@vger.kernel.org Fixes: 7a343c8bf4b5 ("phy: Add Cadence D-PHY support") Signed-off-by: Devarsh Thakkar <devarsht@ti.com> Tested-by: Harikrishna Shenoy <h-shenoy@ti.com> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Link: https://lore.kernel.org/r/20250704125915.1224738-2-devarsht@ti.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/debugging/git:/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions