diff options
| author |   Ville Syrjälä <ville.syrjala@linux.intel.com> | 2025-10-03 17:57:30 +0300 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-23 16:24:33 +0200 |
| commit | aa3d34b9ca046d94873ce9d861a5a26b0862a93d (patch) | |
| tree | d0f4b45822e29a4085d82e5cf5a8b10217a65910 /tools/perf/scripts/python/bin/ssh:/git@git.zx2c4.com | |
| parent | drm/i915/guc: Skip communication warning on reset in progress (diff) | |
drm/i915/frontbuffer: Move bo refcounting intel_frontbuffer_{get,release}()
[ Upstream commit 760039c95c78490c5c66ef584fcd536797ed6a2f ]
Currently xe's intel_frontbuffer implementation forgets to
hold a reference on the bo. This makes the entire thing
extremely fragile as the cleanup order now depends on bo
references held by other things
(namely intel_fb_bo_framebuffer_fini()).
Move the bo refcounting to intel_frontbuffer_{get,release}()
so that both i915 and xe do this the same way.
I first tried to fix this by having xe do the refcounting
from its intel_bo_set_frontbuffer() implementation
(which is what i915 does currently), but turns out xe's
drm_gem_object_free() can sleep and thus drm_gem_object_put()
isn't safe to call while we hold fb_tracking.lock.
Fixes: 10690b8a49bc ("drm/i915/display: Add intel_fb_bo_framebuffer_fini")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20251003145734.7634-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
(cherry picked from commit eb4d490729a5fd8dc5a76d334f8d01fec7c14bbe)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'tools/perf/scripts/python/bin/ssh:/git@git.zx2c4.com')
0 files changed, 0 insertions, 0 deletions