diff options
| author |   Jacob Keller <jacob.e.keller@intel.com> | 2019-07-02 08:22:54 -0400 |
|---|---|---|
| committer |   Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2019-08-05 11:42:05 -0700 |
| commit | 2ad1274fa35ace5c6360762ba48d33b63da2396c (patch) | |
| tree | ac22e4f0947660c0c1b5a645694ac963697ee4f1 /.cocciconfig | |
| parent | i40e: Log disable-fw-lldp flag change by ethtool (diff) | |
| download | linux-dev-2ad1274fa35ace5c6360762ba48d33b63da2396c.tar.xz linux-dev-2ad1274fa35ace5c6360762ba48d33b63da2396c.zip | |
i40e: don't report link up for a VF who hasn't enabled queues
Commit d3d657a90850 ("i40e: update VFs of link state after
GET_VF_RESOURCES") modified the PF driver to notify a VF of
its link status immediately after it requests resources.
This was intended to fix reporting on VF drivers, so that they would
properly report link status.
However, some older VF drivers do not respond well to receiving a link
up notification before queues are enabled. This can cause their state
machine to think that it is safe to send traffic. This results in a Tx
hang on the VF.
More recent versions of the old i40evf and all versions of iavf are
resilient to these early link status messages. However, if a VM happens
to run an older version of the VF driver, this can be problematic.
Record whether the PF has actually enabled queues for the VF. When
reporting link status, always report link down if the queues aren't
enabled. In this way, the VF driver will never receive a link up
notification until after its queues are enabled.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to '.cocciconfig')
0 files changed, 0 insertions, 0 deletions