diff options
| author |   Stefano Brivio <sbrivio@redhat.com> | 2019-06-11 00:27:06 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-06-11 12:07:33 -0700 |
| commit | eccc73a6b2cb6c04bfbc40a0769f3c428dfba232 (patch) | |
| tree | 994badb500db658d9b407df09903fe180bae25a2 /.mailmap | |
| parent | vxlan: Don't assume linear buffers in error handler (diff) | |
| download | linux-dev-eccc73a6b2cb6c04bfbc40a0769f3c428dfba232.tar.xz linux-dev-eccc73a6b2cb6c04bfbc40a0769f3c428dfba232.zip | |
geneve: Don't assume linear buffers in error handler
In commit a07966447f39 ("geneve: ICMP error lookup handler") I wrongly
assumed buffers from icmp_socket_deliver() would be linear. This is not
the case: icmp_socket_deliver() only guarantees we have 8 bytes of linear
data.
Eric fixed this same issue for fou and fou6 in commits 26fc181e6cac
("fou, fou6: do not assume linear skbs") and 5355ed6388e2 ("fou, fou6:
avoid uninit-value in gue_err() and gue6_err()").
Use pskb_may_pull() instead of checking skb->len, and take into account
the fact we later access the GENEVE header with udp_hdr(), so we also
need to sum skb_transport_header() here.
Reported-by: Guillaume Nault <gnault@redhat.com>
Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '.mailmap')
0 files changed, 0 insertions, 0 deletions