diff options
| author |   Eric Dumazet <edumazet@google.com> | 2015-10-04 21:08:10 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-10-05 02:45:25 -0700 |
| commit | 004a5d0140ce1d05c1f5fce5df4baa2717a330e0 (patch) | |
| tree | d6d52b7f3a13ed734e499be05cb4eeaab47ba4da | |
| parent | ipv6: inet6_sk() should use sk_fullsock() (diff) | |
| download | linux-dev-004a5d0140ce1d05c1f5fce5df4baa2717a330e0.tar.xz linux-dev-004a5d0140ce1d05c1f5fce5df4baa2717a330e0.zip | |
net: use sk_fullsock() in __netdev_pick_tx()
SYN_RECV & TIMEWAIT sockets are not full blown, they do not have a
sk_dst_cache pointer.
Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/net/request_sock.h | 1 | ||||
| -rw-r--r-- | net/core/dev.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/include/net/request_sock.h b/include/net/request_sock.h index dd423d840852..f83669460d82 100644 --- a/include/net/request_sock.h +++ b/include/net/request_sock.h @@ -92,6 +92,7 @@ reqsk_alloc(const struct request_sock_ops *ops, struct sock *sk_listener) req->rsk_listener = sk_listener; req_to_sk(req)->sk_prot = sk_listener->sk_prot; sk_node_init(&req_to_sk(req)->sk_node); + sk_tx_queue_clear(req_to_sk(req)); req->saved_syn = NULL; /* Following is temporary. It is coupled with debugging * helpers in reqsk_put() & reqsk_free() diff --git a/net/core/dev.c b/net/core/dev.c index 323c04edd779..a229bf0d649d 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2974,6 +2974,7 @@ static u16 __netdev_pick_tx(struct net_device *dev, struct sk_buff *skb) new_index = skb_tx_hash(dev, skb); if (queue_index != new_index && sk && + sk_fullsock(sk) && rcu_access_pointer(sk->sk_dst_cache)) sk_tx_queue_set(sk, new_index); |