aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNuno Sa <nuno.sa@analog.com>2021-04-27 10:54:49 +0200
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2021-05-17 13:49:09 +0100
commit00a72db718fa198da3946286dcad222399ccd4fb (patch)
tree6f76aa90c324da5521d4c4560c6070bc5568a167
parentiio: accel: Add driver for Murata SCA3300 accelerometer (diff)
downloadlinux-dev-00a72db718fa198da3946286dcad222399ccd4fb.tar.xz
linux-dev-00a72db718fa198da3946286dcad222399ccd4fb.zip
iio: adis16475: do not return ints in irq handlers
On an IRQ handler we should not return normal error codes as 'irqreturn_t' is expected. This is done by jumping to the 'check_burst32' label where we return 'IRQ_HANDLED'. Note that it is fine to do the burst32 check in this error path. If we have proper settings to apply burst32, we might just do the setup now so that the next sample already uses it. Fixes: fff7352bf7a3c ("iio: imu: Add support for adis16475") Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com> Signed-off-by: Nuno Sa <nuno.sa@analog.com> Link: https://lore.kernel.org/r/20210427085454.30616-2-nuno.sa@analog.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
-rw-r--r--drivers/iio/imu/adis16475.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c
index 1de62fc79e0f..51b76444db0b 100644
--- a/drivers/iio/imu/adis16475.c
+++ b/drivers/iio/imu/adis16475.c
@@ -1068,7 +1068,7 @@ static irqreturn_t adis16475_trigger_handler(int irq, void *p)
ret = spi_sync(adis->spi, &adis->msg);
if (ret)
- return ret;
+ goto check_burst32;
adis->spi->max_speed_hz = cached_spi_speed_hz;
buffer = adis->buffer;