diff options
| author |   Joe Eykholt <jeykholt@cisco.com> | 2009-08-25 14:01:23 -0700 |
|---|---|---|
| committer |   James Bottomley <James.Bottomley@suse.de> | 2009-09-10 12:07:44 -0500 |
| commit | 00fea930d404b9a9039291d5a61975e6c2ea974e (patch) | |
| tree | c2d2c32117e74eefdd8876d6903c936cbaf51e06 | |
| parent | [SCSI] libfc: don't create dummy (rogue) remote ports (diff) | |
| download | linux-dev-00fea930d404b9a9039291d5a61975e6c2ea974e.tar.xz linux-dev-00fea930d404b9a9039291d5a61975e6c2ea974e.zip | |
[SCSI] libfc: fix rport event race between READY and LOGO
When a remote port becomes ready and a LOGO is received before
the READY event is in rport_work waiting on the mutex, the
event is changed to LOGO and the work queued, so both the
calls to rport_work see the LOGO event, and both try to do
the list_del(), causing a crash.
Don't change the event if it is already set.
Signed-off-by: Joe Eykholt <jeykholt@cisco.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
| -rw-r--r-- | drivers/scsi/libfc/fc_rport.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index a1794a39158e..cbf6c9f233ca 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c @@ -1267,9 +1267,7 @@ static void fc_rport_recv_logo_req(struct fc_rport_priv *rdata, return; } - rdata->event = RPORT_EV_LOGO; - fc_rport_state_enter(rdata, RPORT_ST_DELETE); - queue_work(rport_event_queue, &rdata->event_work); + fc_rport_enter_delete(rdata, RPORT_EV_LOGO); lport->tt.seq_els_rsp_send(sp, ELS_LS_ACC, NULL); fc_frame_free(fp); |