diff options
| author |   Michael Straube <straube.linux@gmail.com> | 2022-03-29 12:37:54 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-04 07:33:47 +0200 |
| commit | 0166ffdc89bf4d5f50852eb4bc86bbd18cffd4f9 (patch) | |
| tree | 1cdb2c9987e8d58d4333254149e8b7e0a4f6ec49 | |
| parent | staging: r8188eu: refactor rtw_usb_bulk_size_boundary() (diff) | |
| download | linux-dev-0166ffdc89bf4d5f50852eb4bc86bbd18cffd4f9.tar.xz linux-dev-0166ffdc89bf4d5f50852eb4bc86bbd18cffd4f9.zip | |
staging: r8188eu: refactor rtw_inc_and_chk_continual_urb_error()
Refactor rtw_inc_and_chk_continual_urb_error(). Return directly
instead of using a return variable and initialize the variable 'value'
at declaration. This shortens the code and improves readability.
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20220329103756.6740-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/r8188eu/include/usb_ops.h | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/staging/r8188eu/include/usb_ops.h b/drivers/staging/r8188eu/include/usb_ops.h index 3416c8baceb6..cfcf6f84d2cf 100644 --- a/drivers/staging/r8188eu/include/usb_ops.h +++ b/drivers/staging/r8188eu/include/usb_ops.h @@ -27,13 +27,12 @@ */ static inline int rtw_inc_and_chk_continual_urb_error(struct dvobj_priv *dvobj) { - int ret = false; - int value; - value = atomic_inc_return(&dvobj->continual_urb_error); + int value = atomic_inc_return(&dvobj->continual_urb_error); + if (value > MAX_CONTINUAL_URB_ERR) - ret = true; + return true; - return ret; + return false; } /* |