diff options
| author |   Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2022-03-22 14:18:30 +0800 |
|---|---|---|
| committer |   Hans de Goede <hdegoede@redhat.com> | 2022-04-04 15:49:37 +0200 |
| commit | 0284d4d1be753f648f28b77bdfbe6a959212af5c (patch) | |
| tree | 93ed4a0b30d2fd6fe4df036941b0789ccfe40a74 | |
| parent | platform/x86: think-lmi: certificate support clean ups (diff) | |
| download | linux-dev-0284d4d1be753f648f28b77bdfbe6a959212af5c.tar.xz linux-dev-0284d4d1be753f648f28b77bdfbe6a959212af5c.zip | |
platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative
Eliminate the follow smatch warnings:
drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned
'value' is never less than zero.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/samsung-laptop.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/platform/x86/samsung-laptop.c b/drivers/platform/x86/samsung-laptop.c index c1d9ed9b7b67..19f6b456234f 100644 --- a/drivers/platform/x86/samsung-laptop.c +++ b/drivers/platform/x86/samsung-laptop.c @@ -1121,8 +1121,6 @@ static void kbd_led_set(struct led_classdev *led_cdev, if (value > samsung->kbd_led.max_brightness) value = samsung->kbd_led.max_brightness; - else if (value < 0) - value = 0; samsung->kbd_led_wk = value; queue_work(samsung->led_workqueue, &samsung->kbd_led_work); |