diff options
| author |   Markus Elfring <elfring@users.sourceforge.net> | 2019-08-21 21:16:15 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-22 16:22:03 -0700 |
| commit | 038dab7efc38254e151adbbade13b8860055d44a (patch) | |
| tree | ec6d2700641b5b77bb54fcc15bb4d37bb8ae4d1f | |
| parent | mISDN: Delete unnecessary checks before the macro call “dev_kfree_skb” (diff) | |
| download | linux-dev-038dab7efc38254e151adbbade13b8860055d44a.tar.xz linux-dev-038dab7efc38254e151adbbade13b8860055d44a.zip | |
can: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation.
Thus the test around the shown calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Sean Nyekjaer <sean@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/can/spi/hi311x.c | 3 | ||||
| -rw-r--r-- | drivers/net/can/spi/mcp251x.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c index 28badace720e..73d48c3b8ded 100644 --- a/drivers/net/can/spi/hi311x.c +++ b/drivers/net/can/spi/hi311x.c @@ -177,8 +177,7 @@ static void hi3110_clean(struct net_device *net) if (priv->tx_skb || priv->tx_len) net->stats.tx_errors++; - if (priv->tx_skb) - dev_kfree_skb(priv->tx_skb); + dev_kfree_skb(priv->tx_skb); if (priv->tx_len) can_free_echo_skb(priv->net, 0); priv->tx_skb = NULL; diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c index 05547dd36d61..58992fd61cb9 100644 --- a/drivers/net/can/spi/mcp251x.c +++ b/drivers/net/can/spi/mcp251x.c @@ -264,8 +264,7 @@ static void mcp251x_clean(struct net_device *net) if (priv->tx_skb || priv->tx_len) net->stats.tx_errors++; - if (priv->tx_skb) - dev_kfree_skb(priv->tx_skb); + dev_kfree_skb(priv->tx_skb); if (priv->tx_len) can_free_echo_skb(priv->net, 0); priv->tx_skb = NULL; |