diff options
| author |   Hans Verkuil <hverkuil@xs4all.nl> | 2018-11-15 02:49:24 -0500 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-11-20 12:53:30 -0500 |
| commit | 0408b205f1ae60c1b99c9888ac0326543d96a091 (patch) | |
| tree | 5da4260dfa9cc8276ab6b8ab1d0cb0576cd009f9 | |
| parent | media: media-request: Add compat ioctl (diff) | |
| download | linux-dev-0408b205f1ae60c1b99c9888ac0326543d96a091.tar.xz linux-dev-0408b205f1ae60c1b99c9888ac0326543d96a091.zip | |
media: cedrus: add action item to the TODO
Mention that the request validation should increment the memory refcount
of reference buffers so we don't forget to do this.
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| -rw-r--r-- | drivers/staging/media/sunxi/cedrus/TODO | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/staging/media/sunxi/cedrus/TODO b/drivers/staging/media/sunxi/cedrus/TODO index ec277ece47af..a951b3fd1ea1 100644 --- a/drivers/staging/media/sunxi/cedrus/TODO +++ b/drivers/staging/media/sunxi/cedrus/TODO @@ -5,3 +5,8 @@ Before this stateless decoder driver can leave the staging area: * Userspace support for the Request API needs to be reviewed; * Another stateless decoder driver should be submitted; * At least one stateless encoder driver should be submitted. +* When queueing a request containing references to I frames, the + refcount of the memory for those I frames needs to be incremented + and decremented when the request is completed. This will likely + require some help from vb2. The driver should fail the request + if the memory/buffer is gone. |