diff options
| author |   Douglas Anderson <dianders@chromium.org> | 2016-03-07 14:00:53 -0800 |
|---|---|---|
| committer |   Mark Yao <mark.yao@rock-chips.com> | 2016-03-28 14:48:32 +0800 |
| commit | 06b898ec84139b9d5957ec0e275fa0a6a1825df3 (patch) | |
| tree | 7cd0a7c430b86b1544f64c4c4c8f160ad2426f39 | |
| parent | drm/rockchip: vop: Fix vop crtc cleanup (diff) | |
| download | linux-dev-06b898ec84139b9d5957ec0e275fa0a6a1825df3.tar.xz linux-dev-06b898ec84139b9d5957ec0e275fa0a6a1825df3.zip | |
drm/rockchip: dw_hdmi: Don't call platform_set_drvdata()
The Rockchip dw_hdmi driver just called platform_set_drvdata() to get
your hopes up that maybe, somehow, you'd be able to retrieve the 'struct
rockchip_hdmi' from a pointer to the 'struct device'. You can't. When
we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which
clobbers our setting.
Let's just remove the platform_set_drvdata() to avoid dashing people's
hopes.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
| -rw-r--r-- | drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 88776aba984e..d5cfef75fc80 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -271,8 +271,6 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, if (!iores) return -ENXIO; - platform_set_drvdata(pdev, hdmi); - encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); /* * If we failed to find the CRTC(s) which this encoder is |