aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>2022-10-24 21:50:09 +0200
committerVinod Koul <vkoul@kernel.org>2022-11-08 10:43:56 +0530
commit081195d17a0c4c636da2b869bd5809d42e8cbb13 (patch)
tree84d94bc79fa39ce2f468dd54169ed72385fc9bd7
parentdmaengine: apple-admac: Fix grabbing of channels in of_xlate (diff)
downloadlinux-dev-081195d17a0c4c636da2b869bd5809d42e8cbb13.tar.xz
linux-dev-081195d17a0c4c636da2b869bd5809d42e8cbb13.zip
dmaengine: mv_xor_v2: Fix a resource leak in mv_xor_v2_remove()
A clk_prepare_enable() call in the probe is not balanced by a corresponding clk_disable_unprepare() in the remove function. Add the missing call. Fixes: 3cd2c313f1d6 ("dmaengine: mv_xor_v2: Fix clock resource by adding a register clock") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/e9e3837a680c9bd2438e4db2b83270c6c052d005.1666640987.git.christophe.jaillet@wanadoo.fr Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r--drivers/dma/mv_xor_v2.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c
index f629ef6fd3c2..113834e1167b 100644
--- a/drivers/dma/mv_xor_v2.c
+++ b/drivers/dma/mv_xor_v2.c
@@ -893,6 +893,7 @@ static int mv_xor_v2_remove(struct platform_device *pdev)
tasklet_kill(&xor_dev->irq_tasklet);
clk_disable_unprepare(xor_dev->clk);
+ clk_disable_unprepare(xor_dev->reg_clk);
return 0;
}