diff options
| author |   James Smart <jsmart2021@gmail.com> | 2017-09-07 13:18:04 -0700 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2017-09-25 08:56:05 -0600 |
| commit | 0951338d9677f546e230685d68631dfd3f81cca5 (patch) | |
| tree | f77ab72d6c7bf4bf9f8494fb0ef5e85929c99383 | |
| parent | nvme: stop aer posting if controller state not live (diff) | |
| download | linux-dev-0951338d9677f546e230685d68631dfd3f81cca5.tar.xz linux-dev-0951338d9677f546e230685d68631dfd3f81cca5.zip | |
nvme: allow timed-out ios to retry
Currently the nvme_req_needs_retry() applies several checks to see if
a retry is allowed. On of those is whether the current time has exceeded
the start time of the io plus the timeout length. This check, if an io
times out, means there is never a retry allowed for the io. Which means
applications see the io failure.
Remove this check and allow the io to timeout, like it does on other
protocols, and retries to be made.
On the FC transport, a frame can be lost for an individual io, and there
may be no other errors that escalate for the connection/association.
The io will timeout, which causes the transport to escalate into creating
a new association, but the io that timed out, due to this retry logic, has
already failed back to the application and things are hosed.
Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/nvme/host/core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index d470f031e27f..5589f67d2cd8 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -134,8 +134,6 @@ static inline bool nvme_req_needs_retry(struct request *req) return false; if (nvme_req(req)->status & NVME_SC_DNR) return false; - if (jiffies - req->start_time >= req->timeout) - return false; if (nvme_req(req)->retries >= nvme_max_retries) return false; return true; |