diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2021-10-19 08:00:11 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-10-20 11:41:01 +0100 |
| commit | 0b271c48d9c5ca999ca6174a0e9a260c6c312f10 (patch) | |
| tree | 58539f436160dec985b8b79094d1b5c8fa14e5d3 | |
| parent | ethernet: via-rhine: use eth_hw_addr_set() (diff) | |
| download | linux-dev-0b271c48d9c5ca999ca6174a0e9a260c6c312f10.tar.xz linux-dev-0b271c48d9c5ca999ca6174a0e9a260c6c312f10.zip | |
ethernet: via-velocity: use eth_hw_addr_set()
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.
Read the address into an array on the stack, then call
eth_hw_addr_set().
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/via/via-velocity.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/via/via-velocity.c b/drivers/net/ethernet/via/via-velocity.c index 4b9c30f735b5..be2b992f24d9 100644 --- a/drivers/net/ethernet/via/via-velocity.c +++ b/drivers/net/ethernet/via/via-velocity.c @@ -2767,6 +2767,7 @@ static int velocity_probe(struct device *dev, int irq, struct velocity_info *vptr; struct mac_regs __iomem *regs; int ret = -ENOMEM; + u8 addr[ETH_ALEN]; /* FIXME: this driver, like almost all other ethernet drivers, * can support more than MAX_UNITS. @@ -2820,7 +2821,8 @@ static int velocity_probe(struct device *dev, int irq, mac_wol_reset(regs); for (i = 0; i < 6; i++) - netdev->dev_addr[i] = readb(®s->PAR[i]); + addr[i] = readb(®s->PAR[i]); + eth_hw_addr_set(netdev, addr); velocity_get_options(&vptr->options, velocity_nics); |