aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSameeh Jubran <sameehj@amazon.com>2020-02-11 15:17:45 +0000
committerDavid S. Miller <davem@davemloft.net>2020-02-11 17:08:30 -0800
commit0c8923c0a64fb5d14bebb9a9065d2dc25ac5e600 (patch)
tree6f3f581c7e6f8158dfe2d3b723aa99fd24540d44
parentnet: ena: rss: do not allocate key when not supported (diff)
downloadlinux-dev-0c8923c0a64fb5d14bebb9a9065d2dc25ac5e600.tar.xz
linux-dev-0c8923c0a64fb5d14bebb9a9065d2dc25ac5e600.zip
net: ena: rss: fix failure to get indirection table
On old hardware, getting / setting the hash function is not supported while gettting / setting the indirection table is. This commit enables us to still show the indirection table on older hardwares by setting the hash function and key to NULL. Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)") Signed-off-by: Sameeh Jubran <sameehj@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/amazon/ena/ena_ethtool.c14
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
index 08273eb226ee..d44ae4fc9c4e 100644
--- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
+++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
@@ -648,7 +648,21 @@ static int ena_get_rxfh(struct net_device *netdev, u32 *indir, u8 *key,
if (rc)
return rc;
+ /* We call this function in order to check if the device
+ * supports getting/setting the hash function.
+ */
rc = ena_com_get_hash_function(adapter->ena_dev, &ena_func, key);
+
+ if (rc) {
+ if (rc == -EOPNOTSUPP) {
+ key = NULL;
+ hfunc = NULL;
+ rc = 0;
+ }
+
+ return rc;
+ }
+
if (rc)
return rc;