diff options
| author |   Alan Cox <alan@lxorguk.ukuu.org.uk> | 2006-09-25 23:32:34 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-26 08:48:56 -0700 |
| commit | 0f0f1b400ce3c4780b9d974bc69e8b558d99aba4 (patch) | |
| tree | 9346ccc10c544c24b89b4432ad02487406c4c48c | |
| parent | [PATCH] smp_call_function_single() cleanup (diff) | |
| download | linux-dev-0f0f1b400ce3c4780b9d974bc69e8b558d99aba4.tar.xz linux-dev-0f0f1b400ce3c4780b9d974bc69e8b558d99aba4.zip | |
[PATCH] Voyager: tty locking
Voyager fiddles with current->signal.tty without locking. It turns out
that the code in question has already cleared current->signal.tty correctly
because daemonize() does the right thing already.
The signal handling also appears to be incorrect as it does an unprotected
sigfillset that also appears unneccessary. As I don't have a bowtie and am
therefore not a qualified voyager maintainer I leave that to James.
Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | arch/i386/mach-voyager/voyager_thread.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/arch/i386/mach-voyager/voyager_thread.c b/arch/i386/mach-voyager/voyager_thread.c index 50f6de6ff64d..f39887359e8e 100644 --- a/arch/i386/mach-voyager/voyager_thread.c +++ b/arch/i386/mach-voyager/voyager_thread.c @@ -130,7 +130,6 @@ thread(void *unused) init_timer(&wakeup_timer); sigfillset(¤t->blocked); - current->signal->tty = NULL; printk(KERN_NOTICE "Voyager starting monitor thread\n"); |