diff options
| author |   Guenter Roeck <linux@roeck-us.net> | 2014-07-29 20:48:59 -0700 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2014-07-30 21:42:37 -0700 |
| commit | 1074d683a51f1aded3562add9ef313e75d557327 (patch) | |
| tree | bb2de0c2d6bd9e9246e470e16fb3cc2f4003f97f | |
| parent | hwmon: (lm85) Fix various errors on attribute writes (diff) | |
| download | linux-dev-1074d683a51f1aded3562add9ef313e75d557327.tar.xz linux-dev-1074d683a51f1aded3562add9ef313e75d557327.zip | |
hwmon: (lm78) Fix overflow problems seen when writing large temperature limits
On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.
Cc: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Reviewed-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/lm78.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/lm78.c b/drivers/hwmon/lm78.c index 9efadfc851bc..c1eb464f0fd0 100644 --- a/drivers/hwmon/lm78.c +++ b/drivers/hwmon/lm78.c @@ -108,7 +108,7 @@ static inline int FAN_FROM_REG(u8 val, int div) * TEMP: mC (-128C to +127C) * REG: 1C/bit, two's complement */ -static inline s8 TEMP_TO_REG(int val) +static inline s8 TEMP_TO_REG(long val) { int nval = clamp_val(val, -128000, 127000) ; return nval < 0 ? (nval - 500) / 1000 : (nval + 500) / 1000; |