aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorchangzhu <Changfeng.Zhu@amd.com>2019-11-05 18:29:12 +0800
committerAlex Deucher <alexander.deucher@amd.com>2019-11-06 16:27:48 -0500
commit11c610893410b5d550629ce8d10006fdbc2812b4 (patch)
tree8c02698864dc8b54033da8161dd33f1e994e1612
parentdrm/amdgpu: add dummy read by engines for some GCVM status registers in gfx10 (diff)
downloadlinux-dev-11c610893410b5d550629ce8d10006fdbc2812b4.tar.xz
linux-dev-11c610893410b5d550629ce8d10006fdbc2812b4.zip
drm/amdgpu: add warning for GRBM 1-cycle delay issue in gfx9
It needs to add warning to update firmware in gfx9 in case that firmware is too old to have function to realize dummy read in cp firmware. Signed-off-by: changzhu <Changfeng.Zhu@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 65d336b6bc96..6d963f29187c 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -986,6 +986,13 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
adev->gfx.me_fw_write_wait = false;
adev->gfx.mec_fw_write_wait = false;
+ if ((adev->gfx.mec_fw_version < 0x000001a5) ||
+ (adev->gfx.mec_feature_version < 46) ||
+ (adev->gfx.pfp_fw_version < 0x000000b7) ||
+ (adev->gfx.pfp_feature_version < 46))
+ DRM_WARN_ONCE("Warning: check cp_fw_version and update it to realize \
+ GRBM requires 1-cycle delay in cp firmware\n");
+
switch (adev->asic_type) {
case CHIP_VEGA10:
if ((adev->gfx.me_fw_version >= 0x0000009c) &&