diff options
| author |   Javier Martinez Canillas <javierm@redhat.com> | 2022-06-16 09:34:34 +0200 |
|---|---|---|
| committer |   Mark Brown <broonie@kernel.org> | 2022-06-24 16:27:22 +0100 |
| commit | 147b5fffc2cfa00956552f32e64c060d10d84010 (patch) | |
| tree | b28492881830d5fed3838f7734c08a7214e33398 | |
| parent | regmap: Re-introduce bulk read support check in regmap_bulk_read() (diff) | |
| download | linux-dev-147b5fffc2cfa00956552f32e64c060d10d84010.tar.xz linux-dev-147b5fffc2cfa00956552f32e64c060d10d84010.zip | |
regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set
Before adding support to define bulk read/write callbacks in regmap_config
by the commit d77e74561368 ("regmap: Add bulk read/write callbacks into
regmap_config"), the regmap_noinc_read() function returned an errno early
a map->bus->read callback wasn't set.
But that commit dropped the check and now a call to _regmap_raw_read() is
attempted even when bulk read operations are not supported. That function
checks for map->read anyways but there's no point to continue if the read
can't succeed.
Also is a fragile assumption to make so is better to make it fail earlier.
Fixes: d77e74561368 ("regmap: Add bulk read/write callbacks into regmap_config")
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20220616073435.1988219-3-javierm@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/base/regmap/regmap.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index e5bb70374ffc..f37f80a52115 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2904,6 +2904,9 @@ int regmap_noinc_read(struct regmap *map, unsigned int reg, size_t read_len; int ret; + if (!map->read) + return -ENOTSUPP; + if (val_len % map->format.val_bytes) return -EINVAL; if (!IS_ALIGNED(reg, map->reg_stride)) |