diff options
| author |   Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 08:32:22 +0400 |
|---|---|---|
| committer |   Lee Jones <lee@kernel.org> | 2022-07-19 10:54:39 +0100 |
| commit | 1520669c8255bd637c6b248b2be910e2688d38dd (patch) | |
| tree | 80dfcf57a951de976c317b8b3d6b7096e532767f | |
| parent | MAINTAINERS: Fix file entry for MAX77693 DT (diff) | |
| download | linux-dev-1520669c8255bd637c6b248b2be910e2688d38dd.tar.xz linux-dev-1520669c8255bd637c6b248b2be910e2688d38dd.zip | |
mfd: max77620: Fix refcount leak in max77620_initialise_fps
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220601043222.64441-1-linmq006@gmail.com
| -rw-r--r-- | drivers/mfd/max77620.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index fec2096474ad..a6661e07035b 100644 --- a/drivers/mfd/max77620.c +++ b/drivers/mfd/max77620.c @@ -419,9 +419,11 @@ static int max77620_initialise_fps(struct max77620_chip *chip) ret = max77620_config_fps(chip, fps_child); if (ret < 0) { of_node_put(fps_child); + of_node_put(fps_np); return ret; } } + of_node_put(fps_np); config = chip->enable_global_lpm ? MAX77620_ONOFFCNFG2_SLP_LPM_MSK : 0; ret = regmap_update_bits(chip->rmap, MAX77620_REG_ONOFFCNFG2, |