diff options
| author |   Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-10-23 13:08:14 -0500 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-10-24 18:44:42 +0900 |
| commit | 152854025528b30c5ca5113a443ead98c3f1e7a5 (patch) | |
| tree | 1f5f391f310e73115c02d2eb67c5e4eec9e8a28f | |
| parent | bpf: cpumap fix potential lost wake-up problem (diff) | |
| download | linux-dev-152854025528b30c5ca5113a443ead98c3f1e7a5.tar.xz linux-dev-152854025528b30c5ca5113a443ead98c3f1e7a5.zip | |
ipv4: icmp: use BUG_ON instead of if condition followed by BUG
Use BUG_ON instead of if condition followed by BUG in icmp_timestamp.
This issue was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/icmp.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 3c1570d3e22f..1617604c9284 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -968,8 +968,9 @@ static bool icmp_timestamp(struct sk_buff *skb) */ icmp_param.data.times[1] = inet_current_timestamp(); icmp_param.data.times[2] = icmp_param.data.times[1]; - if (skb_copy_bits(skb, 0, &icmp_param.data.times[0], 4)) - BUG(); + + BUG_ON(skb_copy_bits(skb, 0, &icmp_param.data.times[0], 4)); + icmp_param.data.icmph = *icmp_hdr(skb); icmp_param.data.icmph.type = ICMP_TIMESTAMPREPLY; icmp_param.data.icmph.code = 0; |