diff options
| author |   Joe Perches <joe@perches.com> | 2014-10-26 22:25:02 -0700 |
|---|---|---|
| committer |   Lee Jones <lee.jones@linaro.org> | 2014-11-25 16:18:51 +0000 |
| commit | 1753b40f5c97e0d0bf2f0a562603cfc592945a5e (patch) | |
| tree | 5a6201cef20d0a3e1252575360578231cdcf3e50 | |
| parent | mfd: ab8500-sysctrl: Drop ab8500_restart (diff) | |
| download | linux-dev-1753b40f5c97e0d0bf2f0a562603cfc592945a5e.tar.xz linux-dev-1753b40f5c97e0d0bf2f0a562603cfc592945a5e.zip | |
mfd: wm8350-core: Fix probable mask then right shift defect
Precedence of & and >> is not the same and is not left to right.
shift has higher precedence and should be done after the mask.
Add parentheses around the mask.
Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
| -rw-r--r-- | drivers/mfd/wm8350-core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c index 4ab527f5c53b..f5124a8acad8 100644 --- a/drivers/mfd/wm8350-core.c +++ b/drivers/mfd/wm8350-core.c @@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, goto err; } - mode = id2 & WM8350_CONF_STS_MASK >> 10; + mode = (id2 & WM8350_CONF_STS_MASK) >> 10; cust_id = id2 & WM8350_CUST_ID_MASK; chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12; dev_info(wm8350->dev, |