diff options
| author |   Julia Lawall <Julia.Lawall@lip6.fr> | 2016-12-22 13:04:56 +0100 |
|---|---|---|
| committer |   Guenter Roeck <linux@roeck-us.net> | 2017-01-02 10:19:45 -0800 |
| commit | 17c45c4d06ae3d77515a883e57e7e23154c239ae (patch) | |
| tree | 73299d1e60f7f858d64d65ee816ce304ce51aa5e | |
| parent | hwmon: (lm93) use permission-specific DEVICE_ATTR variants (diff) | |
| download | linux-dev-17c45c4d06ae3d77515a883e57e7e23154c239ae.tar.xz linux-dev-17c45c4d06ae3d77515a883e57e7e23154c239ae.zip | |
hwmon: (max1111) use permission-specific DEVICE_ATTR variants
Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source
code, improves readbility, and reduces the chance of inconsistencies.
The conversion was done automatically using coccinelle. It was validated
by compiling both the old and the new source code and comparing its text,
data, and bss size.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
[groeck: Updated description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/max1111.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hwmon/max1111.c b/drivers/hwmon/max1111.c index 303d0c9df907..8ddd4d690652 100644 --- a/drivers/hwmon/max1111.c +++ b/drivers/hwmon/max1111.c @@ -98,7 +98,7 @@ EXPORT_SYMBOL(max1111_read_channel); * likely to be used by hwmon applications to distinguish between * different devices, explicitly add a name attribute here. */ -static ssize_t show_name(struct device *dev, +static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf) { return sprintf(buf, "%s\n", to_spi_device(dev)->modalias); @@ -125,7 +125,7 @@ static ssize_t show_adc(struct device *dev, #define MAX1111_ADC_ATTR(_id) \ SENSOR_DEVICE_ATTR(in##_id##_input, S_IRUGO, show_adc, NULL, _id) -static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); +static DEVICE_ATTR_RO(name); static MAX1111_ADC_ATTR(0); static MAX1111_ADC_ATTR(1); static MAX1111_ADC_ATTR(2); |