aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorIlpo Järvinen <ilpo.jarvinen@helsinki.fi>2007-03-28 12:06:37 -0700
committerDavid S. Miller <davem@sunset.davemloft.net>2007-10-10 16:47:51 -0700
commit19b2b486580f5939688d3e225acdc0f4b291ed0d (patch)
tree7d6803d9decb958769344a28b5ea8e8d65c0d9ca
parent[TCP]: Extracted rexmit hint clearing from the LOST marking code (diff)
downloadlinux-dev-19b2b486580f5939688d3e225acdc0f4b291ed0d.tar.xz
linux-dev-19b2b486580f5939688d3e225acdc0f4b291ed0d.zip
[TCP]: Rexmit hint must be cleared instead of setting it
Stupid error from my side. Even though now that I noticed this, I hoped it would have been an optimization but no, the counter hint is then incorrect. Thus clearing is necessary for now (I still suspect though that this path is never executed). Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/tcp_input.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 7d843c429381..0aa17243d369 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -1776,7 +1776,7 @@ static void tcp_verify_retransmit_hint(struct tcp_sock *tp,
if ((tp->retransmit_skb_hint != NULL) &&
before(TCP_SKB_CB(skb)->seq,
TCP_SKB_CB(tp->retransmit_skb_hint)->seq))
- tp->retransmit_skb_hint = skb;
+ tp->retransmit_skb_hint = NULL;
}
/* Mark head of queue up as lost. */