diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 14:05:24 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-09-27 10:20:36 +0200 |
| commit | 1a4b62a0b8a3b81eca24366f63e214a7144b9f02 (patch) | |
| tree | 11ee966af036023fe3298e3ea60595154c0b26f9 | |
| parent | of: mdio: Fix a signedness bug in of_phy_get_and_connect() (diff) | |
| download | linux-dev-1a4b62a0b8a3b81eca24366f63e214a7144b9f02.tar.xz linux-dev-1a4b62a0b8a3b81eca24366f63e214a7144b9f02.zip | |
net: nixge: Fix a signedness bug in nixge_probe()
The "priv->phy_mode" is an enum and in this context GCC will treat it
as an unsigned int so it can never be less than zero.
Fixes: 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/ni/nixge.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c index 0b384f97d2fd..2761f3a3ae50 100644 --- a/drivers/net/ethernet/ni/nixge.c +++ b/drivers/net/ethernet/ni/nixge.c @@ -1347,7 +1347,7 @@ static int nixge_probe(struct platform_device *pdev) } priv->phy_mode = of_get_phy_mode(pdev->dev.of_node); - if (priv->phy_mode < 0) { + if ((int)priv->phy_mode < 0) { netdev_err(ndev, "not find \"phy-mode\" property\n"); err = -EINVAL; goto unregister_mdio; |