diff options
author | Todd Poynor <toddpoynor@google.com> | 2018-07-21 06:35:04 -0700 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-24 13:56:46 +0200 |
commit | 1d079f20d5aaab58ac6ccc3afd849f7ccebf28a1 (patch) | |
tree | 570b93eb90f342922ac502f1cf36f84fa1f3b0b7 | |
parent | staging: gasket: interrupts: convert various logs to debug level (diff) | |
download | linux-dev-1d079f20d5aaab58ac6ccc3afd849f7ccebf28a1.tar.xz linux-dev-1d079f20d5aaab58ac6ccc3afd849f7ccebf28a1.zip |
staging: gasket: ioctl common: convert various logs to debug level
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/gasket/gasket_core.c | 2 | ||||
-rw-r--r-- | drivers/staging/gasket/gasket_ioctl.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 1d04fd0990e4..732218773c3c 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -1801,7 +1801,7 @@ static long gasket_ioctl(struct file *filp, uint cmd, ulong arg) if (driver_desc->ioctl_handler_cb) return driver_desc->ioctl_handler_cb(filp, cmd, argp); - gasket_log_error( + gasket_log_debug( gasket_dev, "Received unknown ioctl 0x%x", cmd); return -EINVAL; } diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c index 8cf094b90cdb..63e139ab7ff8 100644 --- a/drivers/staging/gasket/gasket_ioctl.c +++ b/drivers/staging/gasket/gasket_ioctl.c @@ -73,7 +73,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp) } } else if (!gasket_ioctl_check_permissions(filp, cmd)) { trace_gasket_ioctl_exit(-EPERM); - gasket_log_error(gasket_dev, "ioctl cmd=%x noperm.", cmd); + gasket_log_debug(gasket_dev, "ioctl cmd=%x noperm.", cmd); return -EPERM; } @@ -132,7 +132,7 @@ long gasket_handle_ioctl(struct file *filp, uint cmd, void __user *argp) * the arg. */ trace_gasket_ioctl_integer_data(arg); - gasket_log_warn( + gasket_log_debug( gasket_dev, "Unknown ioctl cmd=0x%x not caught by " "gasket_is_supported_ioctl", @@ -329,7 +329,7 @@ static int gasket_partition_page_table( gasket_dev->page_table[ibuf.page_table_index]); if (ibuf.size > max_page_table_size) { - gasket_log_error( + gasket_log_debug( gasket_dev, "Partition request 0x%llx too large, max is 0x%x.", ibuf.size, max_page_table_size); |