diff options
| author |   Yu Kuai <yukuai3@huawei.com> | 2022-08-16 09:56:30 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2022-08-22 10:07:56 -0600 |
| commit | 1e3cc2125d7cc7d492b2e6e52d09c1e17ba573c3 (patch) | |
| tree | 8e168bf25b47158023ca3e52b7869971067710ea | |
| parent | block, bfq: remove unused functions (diff) | |
| download | linux-dev-1e3cc2125d7cc7d492b2e6e52d09c1e17ba573c3.tar.xz linux-dev-1e3cc2125d7cc7d492b2e6e52d09c1e17ba573c3.zip | |
block, bfq: remove useless checking in bfq_put_queue()
'bfqq->bfqd' is ensured to set in bfq_init_queue(), and it will never
change afterwards.
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220816015631.1323948-3-yukuai1@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/bfq-iosched.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index c740b41fe0a4..f39067389b2b 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -5255,9 +5255,7 @@ void bfq_put_queue(struct bfq_queue *bfqq) struct hlist_node *n; struct bfq_group *bfqg = bfqq_group(bfqq); - if (bfqq->bfqd) - bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d", - bfqq, bfqq->ref); + bfq_log_bfqq(bfqq->bfqd, bfqq, "put_queue: %p %d", bfqq, bfqq->ref); bfqq->ref--; if (bfqq->ref) @@ -5321,7 +5319,7 @@ void bfq_put_queue(struct bfq_queue *bfqq) hlist_del_init(&item->woken_list_node); } - if (bfqq->bfqd && bfqq->bfqd->last_completed_rq_bfqq == bfqq) + if (bfqq->bfqd->last_completed_rq_bfqq == bfqq) bfqq->bfqd->last_completed_rq_bfqq = NULL; kmem_cache_free(bfq_pool, bfqq); |