aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEvan Quan <evan.quan@amd.com>2022-07-06 16:38:38 +0800
committerAlex Deucher <alexander.deucher@amd.com>2022-07-07 15:54:17 -0400
commit1f374171fd345aaad9fcb30ac3acd255b5cd2076 (patch)
tree6c6aeedc99a1ebb10880e617ad7beef6484500ef
parentdrm/amd/display: remove stale debug setting (diff)
downloadlinux-dev-1f374171fd345aaad9fcb30ac3acd255b5cd2076.tar.xz
linux-dev-1f374171fd345aaad9fcb30ac3acd255b5cd2076.zip
drm/amd/display: correct idle_power_optimizations disablement return value
[Why] The return value indicates whether the operation(disable/enable) succeeded or not. The existing logic reports wrong result even if the disablement was performed successfully. That will make succeeding reenablement abandoned as dc->idle_optimizations_allowed is always true. [How] Correct the return value to reflect the real result of disablement. Fixes: 235c67634230 ("drm/amd/display: add DCN32/321 specific files for Display Core") Signed-off-by: Evan Quan <evan.quan@amd.com> Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
index 1cc1296aed9c..0f1b72ca0397 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c
@@ -377,7 +377,7 @@ bool dcn32_apply_idle_power_optimizations(struct dc *dc, bool enable)
dc_dmub_srv_cmd_execute(dc->ctx->dmub_srv);
dc_dmub_srv_wait_idle(dc->ctx->dmub_srv);
- return false;
+ return true;
}
/* Send DMCUB message with SubVP pipe info