diff options
| author |   Hauke Mehrtens <hauke@hauke-m.de> | 2020-03-02 00:55:02 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-03-03 18:01:33 -0800 |
| commit | 20d8bb0d172d87dcc52727cb7174ae9994de8978 (patch) | |
| tree | 0b19b516e27540f5753fc2142a45f4329682294f | |
| parent | net: phy: bcm63xx: fix OOPS due to missing driver name (diff) | |
| download | linux-dev-20d8bb0d172d87dcc52727cb7174ae9994de8978.tar.xz linux-dev-20d8bb0d172d87dcc52727cb7174ae9994de8978.zip | |
phylink: Improve error message when validate failed
This should improve the error message when the PHY validate in the MAC
driver failed. I ran into this problem multiple times that I put wrong
interface values into the device tree and was searching why it is
failing with -22 (-EINVAL). This should make it easier to spot the
problem.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/phy/phylink.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 70b9a143db84..6e66b8e77ec7 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -761,8 +761,14 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy, config.interface = interface; ret = phylink_validate(pl, supported, &config); - if (ret) + if (ret) { + phylink_warn(pl, "validation of %s with support %*pb and advertisement %*pb failed: %d\n", + phy_modes(config.interface), + __ETHTOOL_LINK_MODE_MASK_NBITS, phy->supported, + __ETHTOOL_LINK_MODE_MASK_NBITS, config.advertising, + ret); return ret; + } phy->phylink = pl; phy->phy_link_change = phylink_phy_change; |