diff options
| author |   Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-08-02 15:48:50 -0400 |
|---|---|---|
| committer | Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-08-02 16:04:29 -0400 |
| commit | 2135e5d56278ffdb1c2e6d325dc6b87f669b9dac (patch) | |
| tree | 40de065272da66c7f812fc3403a5c4f93d1f5a7e | |
| parent | NFS: nfs_async_write_reschedule_io must not recurse into the writeback code (diff) | |
| download | linux-dev-2135e5d56278ffdb1c2e6d325dc6b87f669b9dac.tar.xz linux-dev-2135e5d56278ffdb1c2e6d325dc6b87f669b9dac.zip | |
NFSv4/pnfs: Fix a use-after-free bug in open
If someone cancels the open RPC call, then we must not try to free
either the open slot or the layoutget operation arguments, since they
are likely still in use by the hung RPC call.
Fixes: 6949493884fe ("NFSv4: Don't hold the layoutget locks across multiple RPC calls")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
| -rw-r--r-- | fs/nfs/nfs4proc.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 2d7c14ade193..3ed14a2a84a4 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3096,12 +3096,13 @@ static int _nfs4_open_and_get_state(struct nfs4_opendata *opendata, } out: - if (opendata->lgp) { - nfs4_lgopen_release(opendata->lgp); - opendata->lgp = NULL; - } - if (!opendata->cancelled) + if (!opendata->cancelled) { + if (opendata->lgp) { + nfs4_lgopen_release(opendata->lgp); + opendata->lgp = NULL; + } nfs4_sequence_free_slot(&opendata->o_res.seq_res); + } return ret; } |