diff options
| author |   Colin Ian King <colin.king@canonical.com> | 2017-09-14 17:01:25 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-09-14 10:00:29 -0700 |
| commit | 23f4822207e04c5f78924fe0e5193c14ba720b4c (patch) | |
| tree | e9647e6956452d8ac3054b6e6d788a2acca4c5a6 | |
| parent | tls: make tls_sw_free_resources static (diff) | |
| download | linux-dev-23f4822207e04c5f78924fe0e5193c14ba720b4c.tar.xz linux-dev-23f4822207e04c5f78924fe0e5193c14ba720b4c.zip | |
tg3: clean up redundant initialization of tnapi
tnapi is being initialized and then immediately updated and
hence the initialiation is redundant. Clean up the warning
by moving the declaration and initialization to the inside
of the for-loop.
Cleans up clang scan-build warning:
warning: Value stored to 'tnapi' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/tg3.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index af33dc15c55f..656e6af70f0a 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -11536,11 +11536,11 @@ static int tg3_start(struct tg3 *tp, bool reset_phy, bool test_irq, tg3_napi_enable(tp); for (i = 0; i < tp->irq_cnt; i++) { - struct tg3_napi *tnapi = &tp->napi[i]; err = tg3_request_irq(tp, i); if (err) { for (i--; i >= 0; i--) { - tnapi = &tp->napi[i]; + struct tg3_napi *tnapi = &tp->napi[i]; + free_irq(tnapi->irq_vec, tnapi); } goto out_napi_fini; |