diff options
| author |   Corentin Labbe <clabbe@baylibre.com> | 2021-12-14 17:16:29 +0100 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab@kernel.org> | 2022-01-23 21:18:39 +0100 |
| commit | 241f5b67fb48def58643f279dfb8468bdd54b443 (patch) | |
| tree | 827d59cb81f5310f53eba22766b3fa5e359f9b76 | |
| parent | media: staging: media: zoran: introduce zoran_i2c_init (diff) | |
| download | linux-dev-241f5b67fb48def58643f279dfb8468bdd54b443.tar.xz linux-dev-241f5b67fb48def58643f279dfb8468bdd54b443.zip | |
media: staging: media: zoran: fix usage of vb2_dma_contig_set_max_seg_size
vb2_dma_contig_set_max_seg_size need to have a size in parameter and not
a DMA_BIT_MASK().
While fixing this issue, also fix error handling of all DMA size
setting.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: d4ae3689226e5 ("media: zoran: device support only 32bit DMA address")
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
| -rw-r--r-- | drivers/staging/media/zoran/zoran_card.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/staging/media/zoran/zoran_card.c b/drivers/staging/media/zoran/zoran_card.c index bcf6ef4f0359..bdf15df556e4 100644 --- a/drivers/staging/media/zoran/zoran_card.c +++ b/drivers/staging/media/zoran/zoran_card.c @@ -1282,8 +1282,10 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (err) - return -ENODEV; - vb2_dma_contig_set_max_seg_size(&pdev->dev, DMA_BIT_MASK(32)); + return err; + err = vb2_dma_contig_set_max_seg_size(&pdev->dev, U32_MAX); + if (err) + return err; nr = zoran_num++; if (nr >= BUZ_MAX) { |