diff options
| author |   Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-23 11:56:51 +0800 |
|---|---|---|
| committer |   Marcel Holtmann <marcel@holtmann.org> | 2018-07-23 18:05:01 +0200 |
| commit | 25a13e382de2b0f844cd6303e45f2b33c8fbabac (patch) | |
| tree | 0a36f6fcd5f8094e1454995c0e7618febba92058 | |
| parent | bluetooth: hci_intel: Replace GFP_ATOMIC with GFP_KERNEL in inject_cmd_complete() (diff) | |
| download | linux-dev-25a13e382de2b0f844cd6303e45f2b33c8fbabac.tar.xz linux-dev-25a13e382de2b0f844cd6303e45f2b33c8fbabac.zip | |
bluetooth: hci_qca: Replace GFP_ATOMIC with GFP_KERNEL
qca_open() and qca_set_baudrate() are never called in atomic context.
They call kzalloc() and bt_skb_alloc() with GFP_ATOMIC,
which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
I also manually check the kernel code before reporting it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
| -rw-r--r-- | drivers/bluetooth/hci_qca.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 51790dd02afb..8431be3a837f 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -405,7 +405,7 @@ static int qca_open(struct hci_uart *hu) BT_DBG("hu %p qca_open", hu); - qca = kzalloc(sizeof(struct qca_data), GFP_ATOMIC); + qca = kzalloc(sizeof(struct qca_data), GFP_KERNEL); if (!qca) return -ENOMEM; @@ -891,7 +891,7 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) cmd[4] = baudrate; - skb = bt_skb_alloc(sizeof(cmd), GFP_ATOMIC); + skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL); if (!skb) { bt_dev_err(hdev, "Failed to allocate baudrate packet"); return -ENOMEM; |