diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-03-23 16:05:47 -0700 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2022-03-23 19:00:33 -0700 |
| commit | 25cb5b7ac6a7f7943e22a6831b74a6aa964d2a0c (patch) | |
| tree | 4053d164b28e3260930cf6270e5cd9f02a73978d | |
| parent | ilog2: force inlining of __ilog2_u32() and __ilog2_u64() (diff) | |
| download | linux-dev-25cb5b7ac6a7f7943e22a6831b74a6aa964d2a0c.tar.xz linux-dev-25cb5b7ac6a7f7943e22a6831b74a6aa964d2a0c.zip | |
bitfield: add explicit inclusions to the example
It's not obvious that bitfield.h doesn't guarantee the bits.h inclusion
and the example in the former is confusing. Some developers think that
it's okay to just include bitfield.h to get it working. Change example
to explicitly include necessary headers in order to avoid confusion.
Link: https://lkml.kernel.org/r/20220207123341.47533-1-andriy.shevchenko@linux.intel.com
Fixes: 3e9b3112ec74 ("add basic register-field manipulation macros")
Depends-on: 8bd9cb51daac ("locking/atomics, asm-generic: Move some macros from <linux/bitops.h> to a new <linux/bits.h> file")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: Jan Dąbroś <jsd@semihalf.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | include/linux/bitfield.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/linux/bitfield.h b/include/linux/bitfield.h index 6093fa6db260..c9be1657f03d 100644 --- a/include/linux/bitfield.h +++ b/include/linux/bitfield.h @@ -19,6 +19,9 @@ * * Example: * + * #include <linux/bitfield.h> + * #include <linux/bits.h> + * * #define REG_FIELD_A GENMASK(6, 0) * #define REG_FIELD_B BIT(7) * #define REG_FIELD_C GENMASK(15, 8) |