diff options
| author |   Vlad Buslov <vladbu@mellanox.com> | 2019-02-26 17:34:40 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-02-26 09:17:49 -0800 |
| commit | 268a351d4a77b50a59094cb4592f851880fe8518 (patch) | |
| tree | b55eb097b84af11cfdee69727bb925169cfc5c51 | |
| parent | net: sched: pie: fix mistake in reference link (diff) | |
| download | linux-dev-268a351d4a77b50a59094cb4592f851880fe8518.tar.xz linux-dev-268a351d4a77b50a59094cb4592f851880fe8518.zip | |
net: sched: fix typo in walker_check_empty()
Function walker_check_empty() incorrectly verifies that tp pointer is not
NULL, instead of actual filter pointer. Fix conditional to check the right
pointer. Adjust filter pointer naming accordingly to other cls API
functions.
Fixes: 6676d5e416ee ("net: sched: set dedicated tcf_walker flag when tp is empty")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reported-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/cls_api.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index befc06f658df..478095d50f95 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -238,10 +238,10 @@ static void tcf_proto_put(struct tcf_proto *tp, bool rtnl_held, tcf_proto_destroy(tp, rtnl_held, extack); } -static int walker_check_empty(struct tcf_proto *tp, void *d, +static int walker_check_empty(struct tcf_proto *tp, void *fh, struct tcf_walker *arg) { - if (tp) { + if (fh) { arg->nonempty = true; return -1; } |