diff options
authorRussell King <rmk+kernel@armlinux.org.uk>2019-11-19 17:18:52 +0000
committerDavid S. Miller <davem@davemloft.net>2019-11-19 18:55:02 -0800
commit269a6b5f23a68803c3038faaef96acff2f18d22d (patch)
parentr8169: disable TSO on a single version of RTL8168c to fix performance (diff)
net: phylink: update documentation on create and destroy
Update the documentation on phylink's create and destroy functions to explicitly state that the rtnl lock must not be held while calling these. Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> Signed-off-by: David S. Miller <davem@davemloft.net>
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index a578f7ebf715..da9b5aabe5e4 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -601,6 +601,8 @@ static int phylink_register_sfp(struct phylink *pl,
* Create a new phylink instance, and parse the link parameters found in @np.
* This will parse in-band modes, fixed-link or SFP configuration.
+ * Note: the rtnl lock must not be held when calling this function.
+ *
* Returns a pointer to a &struct phylink, or an error-pointer value. Users
* must use IS_ERR() to check for errors from this function.
@@ -678,6 +680,8 @@ EXPORT_SYMBOL_GPL(phylink_create);
* Destroy a phylink instance. Any PHY that has been attached must have been
* cleaned up via phylink_disconnect_phy() prior to calling this function.
+ *
+ * Note: the rtnl lock must not be held when calling this function.
void phylink_destroy(struct phylink *pl)