diff options
| author |   Chris Packham <chris.packham@alliedtelesis.co.nz> | 2021-04-13 17:09:54 +1200 |
|---|---|---|
| committer |   Wolfram Sang <wsa@kernel.org> | 2021-04-13 14:23:40 +0200 |
| commit | 270282bdf4e5a2484e1244db67e3743cefca6d8f (patch) | |
| tree | 7e78befbd7d41591b42262fe56a397ce105d0040 | |
| parent | i2c: mpc: drop release for resource allocated with devm_* (diff) | |
| download | linux-dev-270282bdf4e5a2484e1244db67e3743cefca6d8f.tar.xz linux-dev-270282bdf4e5a2484e1244db67e3743cefca6d8f.zip | |
i2c: mpc: Remove redundant NULL check
In mpc_i2c_get_fdr_8xxx div is assigned as we iterate through the
mpc_i2c_dividers_8xxx array. By the time we exit the loop div will
either have the value that matches the requested speed or be pointing at
the last entry in mpc_i2c_dividers_8xxx. Checking for div being NULL
after the loop is redundant so remove the check.
Reported-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
| -rw-r--r-- | drivers/i2c/busses/i2c-mpc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 6e5614acebac..3c8bcdfff7e7 100644 --- a/drivers/i2c/busses/i2c-mpc.c +++ b/drivers/i2c/busses/i2c-mpc.c @@ -399,7 +399,7 @@ static int mpc_i2c_get_fdr_8xxx(struct device_node *node, u32 clock, } *real_clk = fsl_get_sys_freq() / prescaler / div->divider; - return div ? (int)div->fdr : -EINVAL; + return (int)div->fdr; } static void mpc_i2c_setup_8xxx(struct device_node *node, |